Add primary heading text to product element #15088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
oliverabrahams
changed the title
emma-imber
approved these changes
Jan 7, 2026
Contributor
emma-imber
left a comment
emma-imber
left a comment
There was a problem hiding this comment.
Nice, will definitely be useful for us in future!
|
Seen on PROD (merged by @oliverabrahams 7 minutes and 45 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a new PrimaryHeadingText to the Product Element and fills it in from the primaryHeadingHtml in the enhancer.
Why?
This will be used for the carousel cards and the horizontal stacked cards.
As it is used in more than one place and to keep the transformation logic away from the components I have added removed the HTML and trailing
:from the PrimaryHeadingHTML in the product element enhancer.